Nested for loops optimisation

5 views (last 30 days)
Virgile Favre
Virgile Favre on 25 Apr 2016
Commented: Virgile Favre on 3 May 2016
Hi there,
I am currently working on a project that involves computation. I need to determine the values of a Ns * Ns symmetric, real matrix.
At the moment I use two for loops to create this matrix, one (let us say with variable a) from 1 to Ns, and the other one ( with j) from j to Ns, in order to use the symmetry of the matrix. the code looks like this :
MATLAB code :
Ns = 30; nc = 1; m = 1; k = 6;
H = rand(Ns, Ns);
H = H + H'; % symmetric, thus will have real eigenvalues
[V, D] = eig(H);
T = Ns * nc / k;
lambda = diag(D);
Y = zeros(Ns, Ns);
for i = 1 : Ns
for j = i : Ns
for l = 1 : T
Y(i, j) = Y(i, j) + real(conj(V(j, l)) * V(i, l) *...
sum(conj(V(i, T + 1 : Ns)) .* V(j, T + 1 : Ns)...
./ (lambda(l) - lambda(T + 1 : Ns))'));
end
if i == j
Y(i, i) = Y(i, i) / 2; % Useful to perform Y = (Y + Y') / 2
end
end
end
Y = -k * (Y + Y'); % This is the actual Y in which I'm interested
% code
V is a Ns * Ns matrix and lambda is some vector of length Ns.
The problem I have is that T is never equal to Ns, thus I cannot write these operations as simple matrix elements, which can be very time-expensive, for example when Ns = 400, 500, ...
I would like to know if anyone could help me vectorize this code.
Edit : clarified somethings for this code to run : example values
  2 Comments
John BG
John BG on 26 Apr 2016
can you get here a working script to start from? I got the following, please amend as appropriate so I can try translating your loops into bsxfun lines, if possible, if i know how to:
Ns=48;nc=10;k=1;V=randi(10,Ns,Ns);D=V;
T = Ns * nc / k;
lambda = diag(D);
Y = zeros(Ns, Ns);
for i = 1 : Ns
for j = i : Ns
for l = 1 : T
Y(i, j) = Y(i, j) + real(conj(V(j, l)) * V(i, l) *sum(conj(V(i, T + 1 : Ns)) .* V(j, T + 1 : Ns)./ (lambda(l) - lambda(T + 1 : Ns))'));
end
% if i == j
% Y(i, i) = Y(i, i) / 2; % Useful to perform X = (X + X') / 2
% end
end
end
Virgile Favre
Virgile Favre on 3 May 2016
I just changed the original post to answer your question

Sign in to comment.

Answers (1)

Dave Behera
Dave Behera on 2 May 2016

Categories

Find more on Loops and Conditional Statements in Help Center and File Exchange

Products

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!